Improve summary module#58
Merged
Merged
Conversation
- added test_outputCSV_streamflow() - added test_outputCSV_basin_and_stream()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve summary module
Refactor and harden the
pyPRMS/summary/module (OutputCSV,OutputVariable,OutputVariables) with code quality improvements and initial test coverage.Changes
Code quality
X | None,dict,list)(object)inheritance from all summary classes__all__export lists to each summary submodule__repr__methods to all summary classesError handling
OutputCSVandOutputVariableconstructors (raiseFileNotFoundErrorwith descriptive message)KeyErrormessages inOutputVariables.get()andwrite_netcdf()Refactoring
OutputVariable.to_xarray()into focused helper methods (_resolve_dim_name,_build_data_array,_set_time_encoding,_set_variable_attrs) with module-level constantsmatchstatement withiffor Python 3.10 compatibilityis_globalmetadata mutation out ofcached_propertyinto a dedicated_set_global_flags()methodTests
OutputCSVcovering streamflow-only and combined basin+streamflow CSV formatsOutputVariablesreading and variable accessFileNotFoundErrorhandling in bothOutputCSVandOutputVariableTarget branch
developmentTesting
All 301 tests pass.