Modernize typing annotations for Python 3.10+#57
Merged
Conversation
- added test_outputCSV_streamflow() - added test_outputCSV_basin_and_stream()
Replace deprecated typing imports (Dict, List, Set, Tuple, Optional, Union, Iterator, Callable, Sequence) with modern equivalents: - Use built-in generics: dict, list, set, tuple - Use PEP 604 union syntax: X | Y, X | None - Use collections.abc for Iterator, Callable, Sequence - Add 'from __future__ import annotations' where needed Files updated: - constants.py - prms_helpers.py - plot_helpers.py - control/Control.py - control/ControlFile.py - control/ControlVariable.py - parameters/Parameters.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize typing annotations for Python 3.10+
Replace deprecated
typingmodule imports with modern Python 3.10+ equivalents across the package.Changes
Dict→dict,List→list,Set→setOptional[X]→X | None,Union[X, Y]→X | Ycollections.abc:Iterator,Callable,Sequenceimported fromcollections.abcinstead oftypingfrom __future__ import annotationsadded to files that needed itFiles updated
pyPRMS/constants.pypyPRMS/prms_helpers.pypyPRMS/plot_helpers.pypyPRMS/control/Control.pypyPRMS/control/ControlFile.pypyPRMS/control/ControlVariable.pypyPRMS/parameters/Parameters.pyWhat's still imported from
typingOnly constructs with no built-in replacement remain:
Any,cast,NamedTuple,Literal.Testing