Improvement: Added Readme for mesh handle tutorials, wiki links still missing. - #2372
Open
Vyp3er wants to merge 3 commits into
Open
Improvement: Added Readme for mesh handle tutorials, wiki links still missing.#2372Vyp3er wants to merge 3 commits into
Vyp3er wants to merge 3 commits into
Conversation
Vyp3er
marked this pull request as ready for review
July 20, 2026 14:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
=======================================
Coverage 82.28% 82.28%
=======================================
Files 125 125
Lines 20701 20701
=======================================
Hits 17033 17033
Misses 3668 3668 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lenaploetzke
self-requested a review
July 21, 2026 07:53
| This is the tutorial collection for the [mesh_handle](../mesh_handle/README.md) interface of `t8code`. | ||
|
|
||
| The `mesh handle` Interface acts as a bridge between the user and the original t8code library. When using the mesh handle, t8code acts as if it is working with usual unstructured meshes. | ||
| For more information about the [mesh_handle](../mesh_handle/README.md), look into the readme there. |
Collaborator
There was a problem hiding this comment.
Suggested change
| For more information about the [mesh_handle](../mesh_handle/README.md), look into the readme there. | |
| Have a look at the [mesh_handle README](../../mesh_handle/README.md) for more information. |
Collaborator
There was a problem hiding this comment.
Please also add the ../ in the link
lenaploetzke
reviewed
Aug 7, 2026
lenaploetzke
left a comment
Collaborator
There was a problem hiding this comment.
Nice, nearly ready to merge :)
| [Mesh Handle Tutorials](../tutorials/mesh_handle/README.md) | ||
| These tutorials can be followed instead of the general t8code tutorials. They explain working with t8code with the help of the | ||
| [mesh_handle](../mesh_handle/README.md) interface. | ||
| Please note, that the mesh handle tutorials start at step 2, because steps 0 and 1 are the same as in the general tutorials. Please complete these first and then come back to the [Mesh Handle Tutorial Overview](../tutorials/mesh_handle/README.md) |
Collaborator
There was a problem hiding this comment.
Suggested change
| Please note, that the mesh handle tutorials start at step 2, because steps 0 and 1 are the same as in the general tutorials. Please complete these first and then come back to the [Mesh Handle Tutorial Overview](../tutorials/mesh_handle/README.md) | |
| Please note, that the mesh handle tutorials start at step 2, because steps 0 and 1 are the same as in the general tutorials. Please complete these first and then come back to the [mesh handle tutorials](../tutorials/mesh_handle/README.md) |
| This is the tutorial collection for the [mesh_handle](../../mesh_handle/README.md) interface of `t8code`. | ||
|
|
||
| The `mesh handle` interface acts as a bridge between the user and the tree-based t8code library. When using the mesh handle, t8code acts as if it is working with usual unstructured meshes. | ||
| Have a look at the [mesh_handle](../mesh_handle/README.md) for more information. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Have a look at the [mesh_handle](../mesh_handle/README.md) for more information. | |
| Have a look at the [mesh handle README](../mesh_handle/README.md) for more information. |
| This is the tutorial collection for the [mesh_handle](../mesh_handle/README.md) interface of `t8code`. | ||
|
|
||
| The `mesh handle` Interface acts as a bridge between the user and the original t8code library. When using the mesh handle, t8code acts as if it is working with usual unstructured meshes. | ||
| For more information about the [mesh_handle](../mesh_handle/README.md), look into the readme there. |
Collaborator
There was a problem hiding this comment.
Please also add the ../ in the link
| [step5](mesh_handle/t8_mesh_step5_element_data.cxx) - | ||
| Associating user data with the elements of a mesh. Exchanging ghost values for element user data. Writing element user data to vtu. | ||
|
|
||
| [step A] - |
Collaborator
There was a problem hiding this comment.
Suggested change
| [step A] - | |
| [stepA] - |
Collaborator
|
And please merge main as there is a merge conflict :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).