Feature: Added Element Methods (get_reference_coordinates, element_is_equal, t8_forest_leaf_face_orientation) - #2360
Open
Vyp3er wants to merge 13 commits into
Open
Feature: Added Element Methods (get_reference_coordinates, element_is_equal, t8_forest_leaf_face_orientation)#2360Vyp3er wants to merge 13 commits into
Vyp3er wants to merge 13 commits into
Conversation
added 9 commits
June 19, 2026 09:37
Vyp3er
marked this pull request as ready for review
July 3, 2026 12:57
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
- Coverage 82.30% 82.28% -0.02%
==========================================
Files 125 125
Lines 20559 20711 +152
==========================================
+ Hits 16922 17043 +121
- Misses 3637 3668 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Collaborator
|
Please clean up the PR and remove changes in files that are not relevant here :) |
lenaploetzke
requested changes
Jul 22, 2026
lenaploetzke
left a comment
Collaborator
There was a problem hiding this comment.
Very cool addition, thank you :)
| @@ -0,0 +1 @@ | |||
| I place my contributions to t8code under the FreeBSD license. Vincent Schmitt (vinz@vincent-schmitt.de) No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Could you merge main? :)
| * \return The orientation of the face with respect to its neighbor. Returns 0 if the face has no neighbor. | ||
| */ | ||
| int | ||
| get_face_orientation (int face) const |
Collaborator
There was a problem hiding this comment.
Very cool function, could you maybe use this one in dg_competences.hxx?
added 2 commits
August 3, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).