Fix for PackageCompiler - #131
Open
Arpit-Babbar wants to merge 2 commits into
Open
Conversation
benegee
requested changes
Jul 28, 2026
benegee
left a comment
benegee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix @Arpit-Babbar !
Given the explanation in trixi-framework/P4est.jl#176 (comment), this seems to be a practical solution.
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to trixi-framework/P4est.jl#176, this PR is needed for T8Code.jl to give distributable executables with PackageCompiler.jl. The CI was failing for me locally for this branch and the master, so I just hope that it passes here somehow. This is needed to make Trixi.jl work with PackageCompiler.jl and later for trixi-framework/Trixi.jl#3151