Skip to content

chore: drop boto for signurlarity#901

Open
natthan-pigoux wants to merge 7 commits into
DIRACGrid:mainfrom
natthan-pigoux:chore_from_boto_to_signurlarity
Open

chore: drop boto for signurlarity#901
natthan-pigoux wants to merge 7 commits into
DIRACGrid:mainfrom
natthan-pigoux:chore_from_boto_to_signurlarity

Conversation

@natthan-pigoux
Copy link
Copy Markdown
Contributor

Closes #712

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 24, 2026

@natthan-pigoux natthan-pigoux force-pushed the chore_from_boto_to_signurlarity branch from ac4a97b to ca6f734 Compare May 21, 2026 08:08
@natthan-pigoux natthan-pigoux force-pushed the chore_from_boto_to_signurlarity branch from ca6f734 to d5ab9a7 Compare May 29, 2026 12:07
@natthan-pigoux
Copy link
Copy Markdown
Contributor Author

natthan-pigoux commented Jun 4, 2026

I just checked why test_upload_download_sandbox was failing with the new client, and I it seems that while uploading a second time the same sandbox , the s3_client.head_object (e.g.signurlarity client) raises:

Access denied to object 'diracAdmin/admin/admin/sha256:24946d6d432b6305e62d87b3becffcbdaa3cbdf1fc8e9a41c5ad3176f994884e.tar.zst' in bucket 'demo-sandboxes'. Check credentials and permissions.

Instead of a 200 response. That is why it uploads a second time the sandbox instead of updating access time.

Any idea why is that?

@natthan-pigoux natthan-pigoux marked this pull request as ready for review June 4, 2026 07:38
@natthan-pigoux
Copy link
Copy Markdown
Contributor Author

Regarding the gubbins-client test. aiohttp dependency is missing now since it was first probably required through some boto dependencies.

In the default pixi env, aiohttp is present but not in the gubbins-client env. Pip shows me:

❯ pixi run -e default pip show aiohttp
Name: aiohttp
Version: 3.14.0
Summary: Async http client/server framework (asyncio)
Home-page: https://github.com/aio-libs/aiohttp
Author: 
Author-email: 
License: Apache-2.0 AND MIT
Location: /home/npigoux/DIRAC/diracx/.pixi/envs/default/lib/python3.11/site-packages
Requires: aiohappyeyeballs, aiosignal, attrs, frozenlist, multidict, propcache, typing_extensions, yarl
Required-by:

❯ pixi run -e gubbins-client pip show aiohttp
WARNING: Package(s) not found: aiohttp

But I don't find any references of the aiohttp dependency in any diracx pyprojet.toml.

Where does it come from? and should I explicitly add the aiohttp in the gubbins-client dependencies.

@natthan-pigoux natthan-pigoux force-pushed the chore_from_boto_to_signurlarity branch from af124e8 to 80ba1d2 Compare June 4, 2026 11:31
@natthan-pigoux natthan-pigoux force-pushed the chore_from_boto_to_signurlarity branch from 80ba1d2 to cf0a40f Compare June 4, 2026 11:33
@natthan-pigoux
Copy link
Copy Markdown
Contributor Author

Where does it come from? and should I explicitly add the aiohttp in the gubbins-client dependencies.

It seems to come from signurlarity.

@aldbr aldbr requested a review from chaen June 4, 2026 11:50
@chaen
Copy link
Copy Markdown
Contributor

chaen commented Jun 4, 2026

It seems to come from signurlarity.

I do not think we explicitly call aiohttp so we should not strictly depend on it. What I find strange is that the gubbins test fail while it does worker for the standard client

@chaen
Copy link
Copy Markdown
Contributor

chaen commented Jun 4, 2026

I just checked why test_upload_download_sandbox was failing with the new client, and I it seems that while uploading a second time the same sandbox , the s3_client.head_object (e.g.signurlarity client) raises:

Access denied to object 'diracAdmin/admin/admin/sha256:24946d6d432b6305e62d87b3becffcbdaa3cbdf1fc8e9a41c5ad3176f994884e.tar.zst' in bucket 'demo-sandboxes'. Check credentials and permissions.

Instead of a 200 response. That is why it uploads a second time the sandbox instead of updating access time.

Any idea why is that?

could that be some crappy config option like you had to update in the signularity tests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop boto

2 participants