Skip to content

feat(handlers): attach trace context to log records - #121

Open
Daniel-Vaz wants to merge 1 commit into
DEVtheOPS:mainfrom
Daniel-Vaz:feat/traceid-in-logs
Open

feat(handlers): attach trace context to log records#121
Daniel-Vaz wants to merge 1 commit into
DEVtheOPS:mainfrom
Daniel-Vaz:feat/traceid-in-logs

Conversation

@Daniel-Vaz

Copy link
Copy Markdown

Description

Log records emitted by the plugin carry no trace context, so they can't be correlated with the spans from the same session.

This makes it difficult to have traces to logs cross signal correlation.

This change attaches a context to all ten emitLog call sites, reusing the existing resolveSessionTraceContext() / resolveRunTraceContext() helpers from util.ts.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Chore (dependency updates, etc.)

Checklist

  • I have read the CONTRIBUTING.md document
  • My code follows the style guidelines of this project
  • bun run lint passes with no errors
  • bun run check:jsdoc-coverage passes with no errors
  • bun run typecheck passes with no errors
  • bun test passes with no errors
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation accordingly
  • My commits follow the Conventional Commits specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant