Redesign budget bar with card layout, gradients, and legend#3533
Open
Rolling2405 wants to merge 6 commits into
Open
Redesign budget bar with card layout, gradients, and legend#3533Rolling2405 wants to merge 6 commits into
Rolling2405 wants to merge 6 commits into
Conversation
- Wrap budget bar in a card component with shadow and title - Show fund cap amount in card header - Add gradient fills to progress bar segments (warning/success) - Add smooth width animation on page load - Replace inline statistics row with color-coded legend badges - Show spent/remaining totals in a bordered footer section - Update data-toggle to data-bs-toggle for Bootstrap 5 - Replace expenditure-block class with budget-bar-segment - Improve responsive layout with flex utilities Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix popover attributes: data-bs-toggle -> data-toggle, data-bs-content -> data-content, data-bs-placement -> data-placement, data-bs-html -> data-html (DARIA uses Bootstrap 4.6.2 which requires data-* not data-bs-*) - Fix text-end -> text-right (BS4 utility class) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update data attributes (data-toggle → data-bs-toggle, etc.) and utility classes (text-right → text-end) for Bootstrap 5 compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace data-bs-* attributes with BS4 data-* equivalents - Replace text-end with text-right for BS4 compatibility - Add nil guard in sum_fund_pledges to return 0 for nil input - Use fetch(:key, []) in budget_bar_remaining for missing keys Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add tests for nil expenditures, nil pledges, missing hash keys - Add tests for negative values, float values, zero ceiling - Add tests for budget_bar_remaining with nil input - 21 new test cases covering 9 identified coverage gaps Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rule and have completed some work on Case Manager that's ready for review!
This redesigns the dashboard budget bar with a card layout, gradient progress bars, and a color-coded legend, making it easier for case managers to see at a glance how fund budgets are being used.
This pull request makes the following changes:
Notes:
#3532→#3533.(If there are changes to the views, please include a screenshot so we know what to look for!)
For reviewer:
featureif it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.dependenciesif it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.