Skip to content

fix: close via menu not hiding correctly #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XanatosX merged 1 commit into from
Jul 11, 2026
Merged

fix: close via menu not hiding correctly #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions entities/game/memory_game/scenes/MemoryGame.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,14 @@ debug_functions = Array[ExtResource("34_4hsit")]([SubResource("Resource_8rpam")]
[connection signal="game_paused" from="." to="Systems/PlayerInputSystem" method="game_paused"]
[connection signal="game_paused" from="." to="World/Camera2D" method="game_paused"]
[connection signal="load_game" from="." to="World/CardBoard/CardInteractionField" method="set_board_information"]
[connection signal="popup_menu_closed" from="." to="UI/PauseMenuButton" method="show_button_if_valid"]
[connection signal="popup_menu_closed" from="." to="UI/PlayersOverlay" method="show"]
[connection signal="popup_menu_closed" from="." to="UI/ZoomButtons/ZoomIn" method="show_button_if_valid"]
[connection signal="popup_menu_closed" from="." to="UI/ZoomButtons/ZoomOut" method="show_button_if_valid"]
[connection signal="popup_menu_shown" from="." to="UI/PauseMenuButton" method="hide"]
[connection signal="popup_menu_shown" from="." to="UI/PlayersOverlay" method="hide"]
[connection signal="popup_menu_shown" from="." to="UI/ZoomButtons/ZoomIn" method="hide"]
[connection signal="popup_menu_shown" from="." to="UI/ZoomButtons/ZoomOut" method="hide"]
[connection signal="request_popup" from="." to="Systems/PopupSystem" method="add_and_show_popup"]
[connection signal="force_close_popup" from="Systems/GameStateSystem" to="Systems/PopupSystem" method="force_close_popup_with_id"]
[connection signal="game_has_ended" from="Systems/GameStateSystem" to="World/CardBoard/CardVisuals" method="hide"]
Expand Down
5 changes: 5 additions & 0 deletions entities/game/memory_game/scripts/MemoryGame.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ signal game_paused(is_paused: bool)

signal request_popup(window: PopupWindow)

signal popup_menu_shown()
signal popup_menu_closed()

signal game_loaded()

const CARDS_PER_PLAYER: int = 2
Expand Down Expand Up @@ -92,6 +95,8 @@ func show_game_menu() -> void:
game_menu = game_menu_template.instantiate() as GamePauseMenu
game_menu.high_priority = true
request_popup.emit(game_menu)
game_menu.popup_closed.connect(func() -> void: popup_menu_closed.emit())
popup_menu_shown.emit()

func set_is_multiplayer() -> void:
_is_local_only = false
Expand Down
Loading