Skip to content

fix: game finish screen showing wrong card back #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XanatosX merged 1 commit into from
Jul 11, 2026
Merged

fix: game finish screen showing wrong card back #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions entities/game/finish_game/scripts/GameFinished.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
class_name GameFinished extends PopupWindow

signal finish_game_ui_loaded(players: Array[PlayerResource], winner: Array[PlayerResource])
signal finish_game_ui_loaded(players: Array[PlayerResource], winner: Array[PlayerResource], deck_texture: Texture)

var manager: PlayerSystem
var played_deck: MemoryDeckResource
Expand All @@ -21,7 +21,7 @@ func _ready() -> void:
if player.score == highest_score:
winners.append(player)

finish_game_ui_loaded.emit(players, winners)
finish_game_ui_loaded.emit(players, winners, played_deck.get_back_image())


func set_player_manager(player_manager: PlayerSystem) -> void:
Expand Down
4 changes: 2 additions & 2 deletions entities/game/finish_game/scripts/PlayerScoreList.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ extends VBoxContainer

var _win_sound_played: bool = false

func build_player_statistic(players: Array[PlayerResource], winners: Array[PlayerResource]) -> void:
func build_player_statistic(players: Array[PlayerResource], winners: Array[PlayerResource], card_texture: Texture) -> void:
players.sort_custom(sort_by_score)
for player: PlayerResource in players:
var player_node: PlayerScoreEntry = player_template.instantiate() as PlayerScoreEntry
Expand All @@ -15,7 +15,7 @@ func build_player_statistic(players: Array[PlayerResource], winners: Array[Playe
if player.id == winner.id:
did_win = true
break
player_node.set_player(player, did_win)
player_node.set_player(player, did_win, card_texture)
add_child(player_node)

func sort_by_score(a: PlayerResource, b: PlayerResource) -> bool:
Expand Down
1 change: 1 addition & 0 deletions entities/game/player_score_entry/scenes/PlayerScoreEntry.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ metadata/_custom_type_script = "uid://bfin0rde3y7nw"

[connection signal="add_new_score" from="." to="PanelContainer/HBoxContainer/PlayerScoreBoard" method="add_score"]
[connection signal="add_new_score" from="." to="EffectPlayer" method="play_effect"]
[connection signal="card_back_changed" from="." to="PanelContainer/HBoxContainer/PlayerScoreBoard" method="set_texture"]
[connection signal="player_changed" from="." to="PanelContainer/HBoxContainer/PlayerName" method="set_text"]
[connection signal="player_did_win" from="." to="PanelContainer/HBoxContainer/PlayerName" method="player_did_win"]
[connection signal="player_did_win" from="." to="PanelContainer/HBoxContainer/MarginContainer/WinningIcon" method="player_did_win"]
Expand Down
4 changes: 3 additions & 1 deletion entities/game/player_score_entry/scripts/PlayerScoreEntry.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ class_name PlayerScoreEntry extends Control
signal set_player_score(score: int)
signal player_changed(name: String)
signal player_did_win(color: ColorResource)
signal card_back_changed(texture: Texture)
signal winner_selected()
signal add_new_score()

Expand All @@ -24,9 +25,10 @@ func _ready() -> void:
if _did_win:
player_did_win.emit(player_win_color)

func set_player(player: PlayerResource, did_win: bool) -> void:
func set_player(player: PlayerResource, did_win: bool, card_texture: Texture) -> void:
_player_data = player
player_changed.emit(player.get_display_name())
card_back_changed.emit(card_texture)
set_player_score.emit(player.score)
_did_win = did_win

Expand Down
Loading