Skip to content

Fix pre-existing clang-format violations in linalg_internal_interface.cpp#960

Merged
manuschneider merged 1 commit into
masterfrom
claude/fix-linalg-format-violations-sgcz85
Jul 1, 2026
Merged

Fix pre-existing clang-format violations in linalg_internal_interface.cpp#960
manuschneider merged 1 commit into
masterfrom
claude/fix-linalg-format-violations-sgcz85

Conversation

@IvanaGyro

@IvanaGyro IvanaGyro commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

  • Reflow the Outer_ii and cuOuter_ii assignment expressions in src/backend/linalg_internal_interface.cpp (lines 228-229 and 723-724) to match clang-format-14 output, the version pinned by .github/workflows/clang-format-check.yml.
  • Both expressions previously broke the line right after =, leaving a line over the 100-column limit; clang-format-14 instead breaks inside the std::vector<...>( argument list.
  • No semantic change — confirmed with git diff --ignore-all-space, which shows no content differences once line-wrap position is ignored.

Context

These two violations are pre-existing on master. git blame traces them to commit bb2e1b29 ("removed using namespace std; from all src files; added missing std:: prefix"), part of PR #952 ("Remove namespace std", merged into master): adding the std:: prefix to vector<std::vector<Outerfunc_oii>>(...) pushed both lines past the formatter's wrap point, and the line break was never re-run through clang-format-14 before merging.

Test plan

  • Verified with clang-format-14 -style=file -output-replacements-xml that the file now has zero replacements
  • Re-ran the same check across every .cpp/.h/.hpp file under src/ and include/ to confirm no other formatting violations are introduced or remain
  • Confirmed the diff is whitespace-only via git diff --ignore-all-space

Reflow the Outer_ii and cuOuter_ii assignment expressions to match
clang-format-14 output, which the clang-format Check CI workflow
enforces. Both expressions exceeded the line-wrap point the
formatter chooses for nested std::vector constructor calls.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reformats the initialization of Outer_ii and cuOuter_ii in src/backend/linalg_internal_interface.cpp to improve line wrapping. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.74%. Comparing base (9b6a407) to head (c6ec1cd).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/backend/linalg_internal_interface.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #960   +/-   ##
=======================================
  Coverage   30.74%   30.74%           
=======================================
  Files         228      228           
  Lines       34757    34757           
  Branches    14411    14411           
=======================================
  Hits        10685    10685           
  Misses      16778    16778           
  Partials     7294     7294           
Flag Coverage Δ
cpp 30.25% <0.00%> (ø)
python 59.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
C++ backend 32.04% <0.00%> (ø)
Python bindings 17.28% <ø> (ø)
Python package 59.41% <ø> (ø)
Files with missing lines Coverage Δ
src/backend/linalg_internal_interface.cpp 80.29% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6a407...c6ec1cd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IvanaGyro IvanaGyro requested a review from manuschneider June 30, 2026 17:18
@manuschneider manuschneider merged commit f891784 into master Jul 1, 2026
18 of 19 checks passed
@manuschneider manuschneider deleted the claude/fix-linalg-format-violations-sgcz85 branch July 1, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants