Fix pre-existing clang-format violations in linalg_internal_interface.cpp#960
Conversation
Reflow the Outer_ii and cuOuter_ii assignment expressions to match clang-format-14 output, which the clang-format Check CI workflow enforces. Both expressions exceeded the line-wrap point the formatter chooses for nested std::vector constructor calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request reformats the initialization of Outer_ii and cuOuter_ii in src/backend/linalg_internal_interface.cpp to improve line wrapping. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #960 +/- ##
=======================================
Coverage 30.74% 30.74%
=======================================
Files 228 228
Lines 34757 34757
Branches 14411 14411
=======================================
Hits 10685 10685
Misses 16778 16778
Partials 7294 7294
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Summary
Outer_iiandcuOuter_iiassignment expressions insrc/backend/linalg_internal_interface.cpp(lines 228-229 and 723-724) to matchclang-format-14output, the version pinned by.github/workflows/clang-format-check.yml.=, leaving a line over the 100-column limit; clang-format-14 instead breaks inside thestd::vector<...>(argument list.git diff --ignore-all-space, which shows no content differences once line-wrap position is ignored.Context
These two violations are pre-existing on
master.git blametraces them to commitbb2e1b29("removed using namespace std; from all src files; added missing std:: prefix"), part of PR #952 ("Remove namespace std", merged intomaster): adding thestd::prefix tovector<std::vector<Outerfunc_oii>>(...)pushed both lines past the formatter's wrap point, and the line break was never re-run through clang-format-14 before merging.Test plan
clang-format-14 -style=file -output-replacements-xmlthat the file now has zero replacements.cpp/.h/.hppfile undersrc/andinclude/to confirm no other formatting violations are introduced or remaingit diff --ignore-all-space