FIX: detect external SP spends to prevent phantom balances - #159
Open
abhayguptas wants to merge 1 commit into
Open
abhayguptas wants to merge 1 commit into
abhayguptas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HDSilentPaymentsWallet.fetchUtxo()does not detect when a Silent Payment (SP) UTXO is spent externally.The wallet refreshes regular UTXOs through Electrum, but does not query the tweaked Taproot addresses belonging to its SP UTXOs.
As a result, an SP UTXO can remain marked as unspent after being spent from another device or wallet. This can cause the wallet to show an incorrect balance and attempt to spend an already-spent output.
Fix
During
fetchUtxo(), query the tweaked Taproot addresses of currently unspent SP UTXOs using the existing Electrum interface.isSpentasfalsewhen the outpoint is present.isSpenttotruewhen the request succeeds but the outpoint is missing.isSpentstate unchanged if the Electrum request fails._utxoso transaction history is preserved.Tests
Added deterministic regression tests covering:
fetchUtxo()behaviorVerification
fixes #158