Skip to content

Fix terminal test readiness and viewport in CI - #1

Merged
CyclopsEyeTeam merged 1 commit into
work/keeper-simple-0.5.0from
fix/manual-close-readiness
Oct 14, 2026
Merged

CyclopsEyeTeam merged 1 commit into
work/keeper-simple-0.5.0from
fix/manual-close-readiness

Conversation

@CyclopsEyeTeam

@CyclopsEyeTeam CyclopsEyeTeam commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Terminal checks could send q after pane creation but before Keeper enabled input. Terminal setup then discarded the early key, causing the manual-close test to time out before its resize assertion. Wait for the existing validated readiness signal before sending the close key.

The original Python 3.10 job also exposed a zero-size PTY in the keyboard test. Give that fixture an explicit 80×24 viewport instead of relying on fallback-on-zero behavior introduced in Python 3.11.

Only tests change. Production code, artwork, golden frames, the three public launch commands, CI workflow and resource criteria remain unchanged. Resource acceptance remains HOLD. No performance matrix was run, and the experimental release tag and installed runtime are unchanged.

Validation:

  • Original manual-close failure reproduced with normal and deliberately delayed startup; both pass after synchronization, with the close/resize/Codex-survival assertions retained.
  • All 138 local functional checks passed after the readiness fix; both affected tests passed on the final diff.
  • The keyboard fixture failed at 0×0 using the official Python 3.10 terminal-size function and passed at 80×24. This compatibility check is not a full Python 3.10 run.
  • Independent review found no issues.
  • Actual GitHub CI passed all 138 tests on both Python 3.10 and 3.12 in the PR workflow and push workflow.

Python documents fallback-on-zero as a 3.11 change.

@CyclopsEyeTeam
CyclopsEyeTeam merged commit 0f456d2 into work/keeper-simple-0.5.0 Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant