Repository navigation
Respect explicitly empty optional configuration values - #95
Merged
Cyclenerd merged 1 commit intoOct 16, 2026
Merged
Conversation
Owner
|
Thank you 馃憤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Complete the Following
Notes
README instructs users to disable the traceroute dependency with
MY_TRACEROUTE_HOST='', and config-example/status.sh documentMY_STATUS_JSON=''to disable JSON output. Currently the:-defaults replace those explicit empty values, so traceroute is still required and status.json is still written. The icon's existing optional-output guard has the same problem.Use unset-only defaults for these three optional settings. Unset options retain their current defaults; explicitly empty options reach the existing dependency/output guards unchanged.
Validation:
bash test-optional-config.shfails on master c698e65 and passes with this change, covering empty options, exclusion from the dependency array and unchanged unset defaults. ShellCheck 0.11.0 passes for status.sh and the regression script; diff whitespace check passes. An isolated full-generator fixture also passed when combined with the independent script-check/duration fixes.Tests ran locally with Git Bash and synthetic inputs. Upstream live-network test.sh and Linux/macOS CI were not run locally.