Repository navigation
Restore arguments and builtins in timed script checks - #94
Merged
Cyclenerd merged 1 commit intoOct 16, 2026
Merged
Conversation
Owner
|
Thank you 馃憤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Complete the Following
Notes
The documented
script;/bin/true parameterA parameterBis reported as down becausetimeoutreceives the complete command as a single executable name. The demo'sscript;exit 80is also reported as down instead of degraded:exitis a shell builtin, not an executable.Run the command/arguments through Bash inside the existing timeout. Keep directly executable paths (including paths with spaces) as one array element, and split the plain command/argument form without evaluating shell syntax. Preserve return-code classification and the timeout.
Validation:
bash test-script-checks.shfails on master c698e65 and passes with this change. Covers relative paths, executable paths with spaces, arguments, exit 80, failure and timeout. ShellCheck 0.11.0 passes for status.sh and the regression script; diff whitespace check passes.Tests ran locally with Git Bash and GNU timeout, synthetic checks and isolated output paths. Network dependencies are stubbed; the upstream live-network test.sh and Linux/macOS CI were not run locally.