Skip to content

Restore arguments and builtins in timed script checks - #94

Merged
Cyclenerd merged 1 commit into
Cyclenerd:masterfrom
dajiaohuang:fix/script-check-arguments-20261015
Oct 16, 2026
Merged

Cyclenerd merged 1 commit into
Cyclenerd:masterfrom
dajiaohuang:fix/script-check-arguments-20261015

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Please Complete the Following

Notes

The documented script;/bin/true parameterA parameterB is reported as down because timeout receives the complete command as a single executable name. The demo's script;exit 80 is also reported as down instead of degraded: exit is a shell builtin, not an executable.

Run the command/arguments through Bash inside the existing timeout. Keep directly executable paths (including paths with spaces) as one array element, and split the plain command/argument form without evaluating shell syntax. Preserve return-code classification and the timeout.

Validation: bash test-script-checks.sh fails on master c698e65 and passes with this change. Covers relative paths, executable paths with spaces, arguments, exit 80, failure and timeout. ShellCheck 0.11.0 passes for status.sh and the regression script; diff whitespace check passes.

Tests ran locally with Git Bash and GNU timeout, synthetic checks and isolated output paths. Network dependencies are stubbed; the upstream live-network test.sh and Linux/macOS CI were not run locally.

@Cyclenerd Cyclenerd self-assigned this Oct 16, 2026
@Cyclenerd
Cyclenerd merged commit 747d468 into Cyclenerd:master Oct 16, 2026
3 checks passed
@Cyclenerd

Copy link
Copy Markdown
Owner

Thank you 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants