You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mirrors the FP cases (FP-46826/46827/46828/46829/46831) as Python test
files so the permissive test-file rubric can be exercised end-to-end.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Defects that should remain reportable even when AI Review applies the
permissive test-file rubric from ENG-4588 (mutable default arg, SQL
injection, identity-vs-equality, file handle leak, off-by-one,
unreachable code, assert-for-auth).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Covers noqa, nosec, skipcq, and pylint disable styles — mix of bare
and code-scoped — so suppression-handling can be exercised against
the permissive test-file rubric.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
We reviewed changes in 9d1323c...cf6500f on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.
The two reliability issues are about tests that can’t actually fail in meaningful ways: catching Exception around assertions and asserting on a constant both give a green check even when behavior is wrong.
Given how thorough and isolated the tests otherwise are, it’s worth making sure every test will reliably go red when behavior regresses.
The reason will be displayed to describe this comment to others. Learn more.
Passing constant to `assertTrue` yields meaningless test
Passing a constant value like True to assertTrue causes the assertion to always pass, defeating the purpose of a test since no real condition is checked. This results in tests that give false confidence by never failing.
Replace the constant argument with an actual condition or use the appropriate assertion method like assertEqual for value comparisons to ensure meaningful test validations.
The variable method is declared and assigned from PROTECTED_ROUTES[i] but never used afterwards, which wastes resources and makes the code less clear. Unused variables make the code harder to read and maintain.
Remove the method variable or rename it to _ to indicate intentional unused usage and clean the codebase.
The reason will be displayed to describe this comment to others. Learn more.
`except Exception` masks failed assertions
test_route_table_is_non_empty suppresses all assertion failures. A broken route table can pass silently, reducing test signal and allowing regressions to merge.
Remove the try/except and assert directly with self.assertGreater(len(ROUTES), 0) so failures are reported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![deepsource-development[bot]](https://avatars.githubusercontent.com/u/40287229?s=60&v=4){kind=small}
No description provided.