Skip to content

Feature/urlc sitemap#157

Merged
lpi-tn merged 6 commits into
mainfrom
Feature/urlc-sitemap
Jul 16, 2026
Merged

Feature/urlc sitemap#157
lpi-tn merged 6 commits into
mainfrom
Feature/urlc-sitemap

Conversation

@lpi-tn

@lpi-tn lpi-tn commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces a new sitemap URL collector to the project, enabling the automated extraction and ingestion of URLs from website sitemaps. The main changes include implementing the sitemap collector logic, integrating it as a new workflow template, and providing comprehensive tests.

New Sitemap Collector Implementation and Integration:

  • Added a new SiteMapURLCollector class in sitemap_collector.py that fetches and parses sitemap XML files (including sitemap indexes), extracts URLs, and stores them in the database.
  • Implemented a new workflow node entrypoint node_sitemap_collect.py to run the sitemap collection as a standalone process, reading configuration from environment variables and handling database insertion.
  • Added a new Argo workflow template (collect-sitemap) to workflow-template.yaml and integrated it into the cron workflow for scheduled collection (including a job for notre-environnement.gouv.fr). [1] [2]

Testing:

  • Added comprehensive unit tests for the sitemap collector, covering sitemap index parsing, URL extraction, error handling, and integration with the database layer.

Workflow Template Adjustments:

  • Minor formatting and whitespace changes in the workflow templates to improve readability. [1] [2]

@lpi-tn
lpi-tn requested a review from sandragjacinto July 16, 2026 14:48
Comment thread welearn_datastack/collectors/sitemap_collector.py Outdated
Co-authored-by: Sandra Guerreiro  <sandragjacinto@gmail.com>
@lpi-tn
lpi-tn merged commit de9d058 into main Jul 16, 2026
3 checks passed
@lpi-tn
lpi-tn deleted the Feature/urlc-sitemap branch July 16, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants