refactor(query): rename getLiteralValue to getValueLiteral - #29
Closed
Curstantine wants to merge 1 commit into
Closed
refactor(query): rename getLiteralValue to getValueLiteral#29Curstantine wants to merge 1 commit into
Curstantine wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Renames the public query utility getLiteralValue to getValueLiteral and updates internal usage and tests accordingly.
Changes:
- Renamed exported function
getLiteralValue→getValueLiteral - Updated
parseSearchParamsto call the renamed function - Updated Vitest suite + added a Changeset marking the rename as a major bump
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/query/src/index.js | Renames the exported function and updates internal call site |
| packages/query/tests/index.test.js | Updates tests/imports to use the new function name |
| .changeset/quick-tigers-grow.md | Declares a major release due to the breaking rename |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @returns {string | null | undefined} | ||
| */ | ||
| export function getLiteralValue(value) { | ||
| export function getValueLiteral(value) { |
Comment on lines
+157
to
160
| export function getValueLiteral(value) { | ||
| if (value === "null") return null; | ||
| if (value === "undefined") return undefined; | ||
| return value; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the exported
getLiteralValuefunction togetValueLiteralin the@jabascript/querypackage, updating all call sites, tests, and generated typings.Changes
packages/query/src/index.js: renamed the function definition and its call site inparseSearchParams.packages/query/tests/index.test.js: updated import, describe block, and all assertions.majorchangeset since this is a breaking public API rename.Verification
pnpm --filter @jabascript/query test: 39 tests passed.pnpm --filter @jabascript/query build:types: clean.pnpm lint: 0 warnings, 0 errors.reactpackage's browser test requires a Playwright chromium binary, which isn't installed in this environment (pre-existing, unrelated to this change).