Implement dynamic safe mode#6
Merged
Merged
Conversation
Closed
BlueWitherer
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A system to automate the Safe Mode state of the mod when the player has the setting for it enabled.
In summary, this proposed implementation stores weak references to registered
horrible::Optionpointers in a new hashmap that are marked as cheating and are enabled by the player, and checks it on API register and user toggle to determine if the player should have safe mode toggled on or off.This also adds new public functions to the mod's API onto
horrible::Optionandhorrible::OptionManagerfor cheat detection. Modders will now be able to mark certain options of theirs as potentially cheating. It is recommended they do this for options that interfere with regular gameplay or base game save data.Several gameplay-based vanilla Horrible Menu options have been marked as cheats as well.