Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates FileUtility to open files with explicit read-only access when probing the file header, aligning file handling with least-required permissions and improving clarity around access intent.
Changes:
- Removes the leading BOM/indentation artifact on the first
usingline. - Updates the header-probe
FileStreamconstruction to explicitly useFileAccess.Read.
Comments suppressed due to low confidence (1)
src/Asn1Editor/API/Utils/FileUtility.cs:44
- The BOM/encoding detection below uses buffer[2] and buffer[3], but the current guard only throws when readBytes < 2. If the file is 2–3 bytes long, the remaining buffer bytes stay 0 (array initialization), which can cause incorrect matches (e.g., UTF-32 check) and misclassify the input. Track readBytes outside the using-block and gate each BOM check by the required byte length (>=3 or >=4).
Int32 readBytes = fs.Read(buffer, 0, 4);
if (readBytes < 2) {
throw new Exception("The data is invalid");
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Code cleanup and minor improvement for file handling.
PR Summary
This pull request consolidates using directives and clarifies file access in the FileUtility class. It improves code readability and ensures explicit file access mode.