-
Notifications
You must be signed in to change notification settings - Fork 34
chore(deps): bump the npm_and_yarn group across 7 directories with 5 updates #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "@crossmint/common-sdk-base": "workspace:*", | ||
| "@datadog/browser-logs": "6.24.1", | ||
| "exponential-backoff": "3.1.1", | ||
| "uuid": "9.0.1", | ||
| "uuid": "14.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The jump from
If this package (or any package that re-exports it) is consumed in a CommonJS context or in an environment running Node 18, it will fail at runtime. Please verify the execution environments and import style before merging. Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/client/base/package.json
Line: 27
Comment:
**uuid v14 carries multiple breaking changes from v9**
The jump from `9.0.1` → `14.0.0` accumulates several breaking changes across intermediate majors:
- **v12**: CommonJS (`require('uuid')`) support was removed — only ESM is supported.
- **v13**: browser exports become the default export condition, which can shift how bundlers resolve the package.
- **v14**: `crypto` must now be globally available, requiring **Node 20+**; Node 18 is no longer supported.
If this package (or any package that re-exports it) is consumed in a CommonJS context or in an environment running Node 18, it will fail at runtime. Please verify the execution environments and import style before merging.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "zod": "3.22.4" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file previously pinned
"next": "^16.2.3"and is being changed to"^15.5.15"— a regression across a major version boundary. Dependabot is grouping this under the "15.x patch" updates affecting other apps, but those apps were already on15.x. Ifapps/wallets/reactintentionally adopted Next.js 16, reverting to^15could remove features or APIs the app depends on. Please confirm this downgrade is intentional before merging.Prompt To Fix With AI