Polish Radar source action and isolate local Electron tests - #219
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
What changed\n\n- Shortens and compacts the Radar source action while preserving its accessible label.\n- Keeps Electron E2E windows visible without stealing desktop focus.\n- Suppresses external app/browser launches during Electron tests.\n- Creates the disposable E2E PocketBase administrator before first startup so PocketBase cannot open its setup page in Safari.\n- Adds focused unit and end-to-end regression coverage for each boundary.\n\n## User impact\n\nLocal Electron test runs no longer steal focus or open PocketBase, browser, or Teams tabs. Normal Relay behavior is unchanged because the guard is enabled only by the Electron test runner in test mode.\n\n## Verification\n\n- npm run typecheck\n- npm run lint\n- npm run format:check\n- npm test (5,586 passed, 1 skipped)\n- npm run build\n- npm audit --audit-level=high --omit=dev (0 vulnerabilities)\n- npm run test:electron (40 passed)\n- npm run test:web (Chrome, Edge, Safari; 3 passed)\n- git diff --check\n- Safari before/after full Electron run: 3 total tabs, 0 PocketBase setup tabs