Skip to content

Fix Entities Default Path#808

Open
MattToast wants to merge 4 commits into
CrayLabs:developfrom
MattToast:fix-entities-default-path
Open

Fix Entities Default Path#808
MattToast wants to merge 4 commits into
CrayLabs:developfrom
MattToast:fix-entities-default-path

Conversation

@MattToast
Copy link
Copy Markdown
Member

Make default path for Models, Ensembles, and Orchestrators the current working directory at runtime when constructing manually.

Fixes #556

@MattToast MattToast requested a review from ashao May 21, 2026 00:21
@MattToast MattToast self-assigned this May 21, 2026
@MattToast MattToast added the release:052026 To be addressed as part of the May 2026 maintenance release label May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.17%. Comparing base (d7d979e) to head (befa872).
⚠️ Report is 28 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #808      +/-   ##
===========================================
- Coverage    83.91%   80.17%   -3.74%     
===========================================
  Files           83       78       -5     
  Lines         6284     6093     -191     
===========================================
- Hits          5273     4885     -388     
- Misses        1011     1208     +197     
Files with missing lines Coverage Δ
smartsim/database/orchestrator.py 78.67% <ø> (-7.09%) ⬇️
smartsim/entity/ensemble.py 99.35% <100.00%> (+0.09%) ⬆️
smartsim/entity/entityList.py 96.00% <ø> (-4.00%) ⬇️
smartsim/entity/model.py 96.04% <100.00%> (-0.04%) ⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:052026 To be addressed as part of the May 2026 maintenance release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected path attr set for SmartSim entities when passing an Optional path param

1 participant