Skip to content

Audit workflows with offline zizmor in workflow lint - #218

Merged
woksin merged 3 commits into
mainfrom
ci-187-verify-workflows
Oct 30, 2026
Merged

woksin merged 3 commits into
mainfrom
ci-187-verify-workflows

Conversation

@woksin

@woksin woksin commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Added

@woksin woksin added the minor label Oct 30, 2026
@woksin woksin self-assigned this Oct 30, 2026
@woksin

woksin commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes:

  • This slice covers the zizmor audit only. Still open under Lint workflow changes with actionlint and zizmor, and roll out SHA-pinned actions and job-level permissions #187: SHA-pinning the remaining actions, rolling out job-level permissions, and clearing the 14 existing zizmor findings so that blocking can become the default.
  • Local checks:
    • workflow-lint tests (8), including offline tests that a substituted archive is rejected before extraction on both architectures;
    • actionlint;
    • shellcheck.
  • Not run locally: the installer's real download and checksum step, because it is Linux-only. Smoke CI covers it.
  • Two quick review rounds. The first asked for hostile-case installer tests; they were added and the second round passed.

@woksin
woksin merged commit 5f4739c into main Oct 30, 2026
11 checks passed
@woksin
woksin deleted the ci-187-verify-workflows branch October 30, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant