Repository navigation
Add java-version input to update-packages - #209
Merged
Merged
Conversation
A 403 on one package's version listing no longer fails the whole job: cleanup warns, skips that package without deleting anything from it, and cleans up the rest. Manual apply still fails when a package was skipped, and a 403 outside inventory still fails.
Contributor
Author
|
Test plan: cleanup-pr-artifacts.test.py (44 tests, incl. new 403-skip, skipped-package manual-apply failure and 403-outside-inventory cases), update-packages.test.py, workflow-lint.test.py and actionlint all pass locally. Full review (Opus + Sol) passed with no blocking findings; the advisory about no test for the java-version input was not acted on. |
The package-update rollout must not ship with a change that triggers Bootstrap Common Workflows.
woksin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
update-packages.ymltakes ajava-versioninput (default21) for the JDK used by Gradle updates, so callers whose Gradle toolchain needs another JDK, such as 17, can set it. (update-packages.yml hardcodes JDK 21 with no caller override, breaking Gradle callers pinned to a different toolchain #138)