Repository navigation
Correct why verify-release-notes fails a (#n) inside an HTML comment - #207
Merged
Merged
Conversation
Since release-action v1.4.2 removes closed HTML comments before it publishes and closes issues, a hidden (#n) closes nothing. The check still fails it; the comments, error message, README and spec now say why.
Contributor
Author
|
Reviewer notes: validation unchanged; only comments, the error message, README and one spec name/assertion. The release-notes program is embedded byte-identically in verify-pull-request-policy.yml, so both copies change. The managed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
(#n)inside an HTML comment fails: release-action removes the comment together with the reference, so the issue is not closed. Write the(#n)at the end of the delivering bullet, outside the comment. The check still fails such a reference. (verify-release-notes says a (#n) inside an HTML comment still closes the issue - no longer true since release-action v1.4.2 #149)