Skip to content

Lint and smoke-run workflow changes on the pull request - #195

Merged
woksin merged 2 commits into
mainfrom
ci-192-workflow-smoke
Oct 23, 2026
Merged

woksin merged 2 commits into
mainfrom
ci-192-workflow-smoke

Conversation

@woksin

@woksin woksin commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Workflow changes in this repository are now linted and smoke-run on the pull request, before they reach main and every consumer.

Added

  • Reusable workflow-lint.yml: runs a pinned, checksum-verified actionlint over all of a caller's workflows (optionally shellcheck and extra files), using the caller's .github/actionlint.yaml when present or a shared configuration that knows the Cratis runner labels. (part of Give workflow-file changes a non-target PR smoke job #192)
  • smoke-workflows.yml: on pull requests that change workflows, actions or templates, calls the read-only reusable workflows from the pull request's own commit, so a broken reusable fails its PR instead of every consumer after merge. Workflows that need secrets or write access are listed as not smokeable, with a manual fallback documented in the README. (part of Give workflow-file changes a non-target PR smoke job #192)

Changed

@woksin woksin self-assigned this Oct 23, 2026
@woksin

woksin commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes (not release notes)

  • Tracks Give workflow-file changes a non-target PR smoke job #192 (phase 1: Workflows repo only; consumer rollout Arc → Stage → Chronicle → Studio follows in separate PRs).
  • Local: actionlint, actionlint .github/templates/publish.template.yml, workflow-lint.test.py, verify-public-runners.test.py, workflow-templates.test.py, bootstrap-policy.test.py, verify-release-notes.spec.mjs, bash -n install-actionlint.sh all exit 0.
  • Full cross-provider review (Opus + Sol) at f52361b: passed, no findings; installer checksums verified against upstream actionlint 1.7.12.
  • Not verified locally: GitHub-hosted execution. This PR's own Smoke Workflows run is the first hosted run; I will also open a throwaway PR with a deliberately broken workflow to prove lint fails, then close it.
  • Decisions: release-policy reusables are NOT_SMOKEABLE (decide separately), the smoke check is not a required check, no PR template edit, ubuntu-latest.

@woksin
woksin merged commit 525ab45 into main Oct 23, 2026
14 checks passed
@woksin
woksin deleted the ci-192-workflow-smoke branch October 23, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant