Repository navigation
Fix the VS Code event model board crashing on view options, and keep them for the user - #325
Merged
Merged
Conversation
The watermark showed only the Cratis mark, taken from Studio's logo. It now shows the full Cratis logo, white, in the upper left of the board. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrnFQW3Zx9PqPJgwE4b7Kc
A failure while drawing the board took the whole webview down with no trace of what went wrong. The board now says what failed, logs it to the webview console, and offers to go back to the default view - which also gets past a view option VS Code has kept for the editor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrnFQW3Zx9PqPJgwE4b7Kc
Changing a view option crashed the board in VS Code: the presentation was kept with an effect that returned what the webview's setState returned, which React then called as the effect's cleanup. The extension now keeps the view options in VS Code's storage for the user instead - every board and every later session opens with the last choice, and a change on one open board is shown on the others. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrnFQW3Zx9PqPJgwE4b7Kc
The error boundary sits around the board alone, so the view options stay usable when the board fails to draw; choosing another one now draws the board again instead of leaving the failure in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrnFQW3Zx9PqPJgwE4b7Kc
einari
changed the title
einari
marked this pull request as ready for review
October 1, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Fixed