Repository navigation
Recognize keyword modifiers on concept declarations in the editor - #1084
Merged
Merged
Conversation
einari
added
patch
Contributor
Author
|
Corpus impact: none - this changes only the editor's symbol scanner, so no language construct, diagnostic or generated output changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
@attributemodifiers after a concept's primitive, soconcept SpeakerEmail : String pii(the documented form) was not recognized as a concept. Every use of it showed an unknown-type squiggle, althoughcratis screenplay validateaccepted the model. The scanner now accepts the keyword modifiers (pii,secret) with or without@.