Skip to content

Keep specifications out of the published Scene packages - #57

Merged
woksin merged 2 commits into
mainfrom
fix/40-exclude-specs-from-package
Sep 30, 2026
Merged

woksin merged 2 commits into
mainfrom
fix/40-exclude-specs-from-package

Conversation

@woksin

@woksin woksin commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Fixed

@woksin woksin self-assigned this Sep 30, 2026
@woksin woksin added the patch label Sep 30, 2026
@woksin

woksin commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Design note: tsc -b type-checks and emits the for_* specs with everything else, and all eight packages leaked them (65/75/220/105/5/85/60/5 spec files in blueprint.components/blueprint.default/components/engine/model/primereact/react/tailwind, as dist/esm output and as **/*.ts sources). The tsconfig files are unchanged on purpose, so specs are still type-checked by tsc -b; the boundary is each package's files list (!**/for_*/**), which is what npm publish packs. verify-package-contents.js (yarn verify-packages, run in javascript-build.yml after yarn ci) packs each public workspace with npm pack --dry-run and fails on any for_* path or a runtime script importing vitest, chai, sinon or Testing Library.

Local checks: yarn ci (clean, lint:ci, build and tests for all 8 workspaces) and yarn verify-packages pass; with the files exclusion reverted for @cratis/scene.model, yarn verify-packages fails naming the spec files. build-storybook runs only in CI and is unaffected.

@woksin
woksin merged commit 85db5ec into main Sep 30, 2026
4 checks passed
@woksin
woksin deleted the fix/40-exclude-specs-from-package branch September 30, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant