You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Keep specifications out of the published Scene packages - #57
The published @cratis/scene.* packages no longer contain compiled or source specification modules (for_* folders), so a package archive holds only its runtime output, declarations and sources. (Keep compiled specifications out of runtime package artifacts #40)
Design note: tsc -b type-checks and emits the for_* specs with everything else, and all eight packages leaked them (65/75/220/105/5/85/60/5 spec files in blueprint.components/blueprint.default/components/engine/model/primereact/react/tailwind, as dist/esm output and as **/*.ts sources). The tsconfig files are unchanged on purpose, so specs are still type-checked by tsc -b; the boundary is each package's files list (!**/for_*/**), which is what npm publish packs. verify-package-contents.js (yarn verify-packages, run in javascript-build.yml after yarn ci) packs each public workspace with npm pack --dry-run and fails on any for_* path or a runtime script importing vitest, chai, sinon or Testing Library.
Local checks: yarn ci (clean, lint:ci, build and tests for all 8 workspaces) and yarn verify-packages pass; with the files exclusion reverted for @cratis/scene.model, yarn verify-packages fails naming the spec files. build-storybook runs only in CI and is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
@cratis/scene.*packages no longer contain compiled or source specification modules (for_*folders), so a package archive holds only its runtime output, declarations and sources. (Keep compiled specifications out of runtime package artifacts #40)