Repository navigation
Add signal interaction trigger for extension component signals - #313
Merged
Merged
Conversation
A screen's 'on <signal>' handles a signal an extension component raises. Model it as SignalInteractionTrigger and resolve it with resolveSignalBehaviors, separately from application triggers.
Contributor
Author
|
Verified locally: model and engine build, lint and tests pass (241 and 3227 tests), Model.Specs 55 pass. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scene can now bind a screen interaction
on <signal>to a signal an extension component raises.Added
SignalInteractionTrigger(signalName) in@cratis/scene.modelandCratis.Scene.Model.Interactions, a new interaction trigger kind next to the built-in, event, interval and application-trigger kinds. Existing triggers and documents are unchanged.resolveSignalBehaviors(attachments, signalName)in@cratis/scene.engine, which collects the bindings for a raised signal in the same deterministic order as the other triggers and never matches an application trigger of the same name.