Skip to content

Compare enum guard values by their declared member numbers - #282

Merged
woksin merged 2 commits into
mainfrom
scene-enum-guard-numbers
Nov 3, 2026
Merged

woksin merged 2 commits into
mainfrom
scene-enum-guard-numbers

Conversation

@woksin

@woksin woksin commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Fixed

@woksin woksin added the minor label Nov 3, 2026
@woksin woksin self-assigned this Nov 3, 2026
@woksin

woksin commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes (not part of the release note)

  • Delivered by the implementing lane: one commit d38f45c on top of Opt-in strict string operands for Contains guards #279, plus a merge of origin/main (Write component properties as indented blocks in the foundation docs #281 docs only, no overlap).
  • Additive contract change: optional enumerationNumbers on ComparisonGuardCondition. An older engine ignores it and keeps positional comparison; a new engine without the field uses the unchanged positional path. Old JSON is byte-identical.
  • Alternatives considered: replacing enumeration with name/number pairs (breaking, rejected); resolving numbers in the engine from names (no source of numbers there, rejected).
  • Full whole-change cross-provider review (including security) passed with no findings.
  • Delivery gates: Engine.Specs and Model.Specs Release -warnaserror; Engine.Specs 181/181, Model.Specs 45/45; model and engine yarn ci. Owner gate: whole-solution Release build.

@woksin
woksin merged commit f9413b5 into main Nov 3, 2026
@woksin
woksin deleted the scene-enum-guard-numbers branch November 3, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant