You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change: CoreGuardedAction reads CommandOutcome.exceptionMessages and validationErrors and combines them into the thrown error (trimmed, blank entries dropped, newline-joined). The generic text remains the fallback. Dispatchers stay outcome-based.
Specs: for_CoreGuardedAction/when_running_a_guarded_command.tsx adds cases for exception messages, validation messages, both together, and the empty fallback. They failed before the fix and pass after it.
Local: scene.react tests, lint:ci and build pass. In the full yarn ci, one untouched spec failed: primereact/for_editor/when_sanitizing_hostile_html (the 5000-deep nesting case took 6.8 s against the 5 s test timeout, with machine load around 60). It is in a workspace this PR does not touch, and it passed in CI on the same tree (run 40890014802). CI is the authority here.
Advisory from review, not changed: ActionStatus may show the joined messages on one line. A follow-up can render line breaks if needed.
Downstream: Stage#857 consumes this through a Scene bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed