Skip to content

Toolbar buttons carry their title as an explicit aria-label - #277

Merged
woksin merged 1 commit into
mainfrom
scene-254-toolbar-aria-label
Oct 29, 2026
Merged

woksin merged 1 commit into
mainfrom
scene-254-toolbar-aria-label

Conversation

@woksin

@woksin woksin commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Fixed

@woksin

woksin commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Notes for reviewers

  • Scope: Toolbar buttons with an icon and secondary emphasis draw no label and have no accessible name #254. Since v4.78.6 (21114f2) the toolbar button has its title as tooltip and accessible name. This PR adds the explicit aria-label that the issue asks for, plus a spec assertion.
  • Out of scope, by design: compact topbar and slim rail layouts hide button labels and the application name. That's a layout choice.
  • Local checks: whole-repo JS build, Source/JavaScript/react specs and lint (lint:ci) all pass. The remaining yarn ci workspaces, browser shards and .NET specs run in CI.
  • Review: quick review round, passed, no findings. Assigned to woksin; this PR is authored as woksin, so no review request.

@woksin
woksin merged commit 33ed677 into main Oct 29, 2026
7 of 8 checks passed
@woksin
woksin deleted the scene-254-toolbar-aria-label branch October 29, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant