Skip to content

Neutral gallery templates and PrimeReact-aware previews - #274

Merged
woksin merged 5 commits into
mainfrom
scene-251-neutral-gallery
Oct 26, 2026
Merged

woksin merged 5 commits into
mainfrom
scene-251-neutral-gallery

Conversation

@woksin

@woksin woksin commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Added

Changed

Fixed

Landing, ModuleWorkspace, FeatureSection and SliceSection no longer
require component packages, ConfirmDialog is pinned as neutral, and
gallery previews choose the full profile only when every declared
package is loaded, keeping the partial-bundle profile otherwise.
PrimeReact's gallery subset declares text and card but not button, so
button resolves to core under both profiles.
Declare PrimeReact button in the gallery catalog subset, select the full gallery profile only when every borrowed PrimeReact name is registered, and describe the conditional selection in the README.
@woksin woksin added the minor label Oct 26, 2026
@woksin woksin self-assigned this Oct 26, 2026
@woksin

woksin commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes

  • Scope: Scene#251 slice 1, which covers preview-profile isolation and the neutral gallery templates. The accepted decisions are:
  • Review history:
    • Sol partial round 1 failed. It found button missing from the PrimeReact catalog subset and a profile switch on a single registered key. Both were fixed, and Sol round 2 passed.
    • The whole-change review (fa5936d..fb95acd) failed in both Opus and Sol. Opus found the templates were relabelled, not rewritten. Sol found PrimeButton ignored interactions.
    • The fix is 7da54ba. The delta round 2 (fb95acd..7da54ba) passed in both Opus and Sol, with no blocking or advisory findings.
    • The review workflow could not start in this session (process.cwd ENOENT), so the same Opus and Sol reviewers were run directly.
  • Local gates at 7da54ba:
    • blueprint.default: lint, test (1830) and build pass.
    • primereact: lint, test (560) and build pass.
    • yarn verify-packages, yarn verify-blueprints and yarn build-storybook pass. verify-packages and build-storybook last ran at fb95acd.
    • Full yarn ci passes.
  • Not run locally: browser specs (CI runs them), the blueprint-scaffold CI step and the .NET build (no .NET changes).
  • CodeScene: the implementer's safeguard reported no declines. The CodeScene MCP was not available to the main session.

@woksin
woksin merged commit 2d8bd61 into main Oct 26, 2026
7 of 8 checks passed
@woksin
woksin deleted the scene-251-neutral-gallery branch October 26, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant