Repository navigation
Neutral gallery templates and PrimeReact-aware previews - #274
Merged
Merged
Conversation
Landing, ModuleWorkspace, FeatureSection and SliceSection no longer require component packages, ConfirmDialog is pinned as neutral, and gallery previews choose the full profile only when every declared package is loaded, keeping the partial-bundle profile otherwise.
PrimeReact's gallery subset declares text and card but not button, so button resolves to core under both profiles.
Declare PrimeReact button in the gallery catalog subset, select the full gallery profile only when every borrowed PrimeReact name is registered, and describe the conditional selection in the README.
Contributor
Author
Reviewer notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
actionButtontakes an optionalicon, shown as a decorative PrimeIcons icon beside the label. (part of Gallery templates render with React Aria by default, not only with PrimeReact #251)Changed
Fixed