Repository navigation
Add guarded actions that pick their command from the selected item - #272
Merged
Merged
Conversation
…roperties The options-level camelCase enum converter overrode the guard enums' own converters, so ToProperties wrote values the engines fail closed on.
Contributor
Author
|
Notes for reviewers (not part of the release note) Local gates on 0328773
Review: two cross-provider rounds. Round 1 found one blocker: Code Health: CodeScene's change-set gate reports "failed". The owner accepted these findings:
Not run locally: hosted CI. Production UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A screen action can now pick its command from the selected item's state, so a Screenplay
actionwithwhen … execute …alternatives renders as one button instead of being refused.Added
core:guarded-actioncomponent: an action with orderedwhen <condition> execute <Command>alternatives runs the first alternative whose condition holds for the selected item, falls back tootherwise execute <Command>or hides itself, and stays hidden while nothing is selected. See Guarded actions. (Guarded screen actions: pick the command from the selected item's state #68)== null, and a condition that cannot be evaluated fails closed with diagnosticSCENE-GUARD-001. (Guarded screen actions: pick the command from the selected item's state #68)InteractionContextaccepts an optionalsubject, the item an interaction acts on. (Guarded screen actions: pick the command from the selected item's state #68)