Skip to content

Add guarded actions that pick their command from the selected item - #272

Merged
woksin merged 8 commits into
mainfrom
scene-68-guarded-action
Oct 26, 2026
Merged

woksin merged 8 commits into
mainfrom
scene-68-guarded-action

Conversation

@woksin

@woksin woksin commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

A screen action can now pick its command from the selected item's state, so a Screenplay action with when … execute … alternatives renders as one button instead of being refused.

Added

@woksin woksin added the minor label Oct 26, 2026
@woksin woksin self-assigned this Oct 26, 2026
@woksin

woksin commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Notes for reviewers (not part of the release note)

Local gates on 0328773

  • Release build: dotnet build Scene.slnx -c Release --no-incremental /p:TreatWarningsAsErrors=true. Zero warnings or errors.
  • Release specs: Engine 177 and Model 40 pass.
  • The JavaScript last changed at 1061de8. Run at 1061de8 and still valid: yarn ci, verify-packages and verify-blueprints, the scaffold proof, the Storybook build and the 17 browser suites.

Review: two cross-provider rounds. Round 1 found one blocker: GuardedActionProperties.ToProperties wrote camelCase guard enums that the engines then refused. It is fixed in 0328773 with a regression spec that fails without the fix. Round 2 found no blocking issues.

Code Health: CodeScene's change-set gate reports "failed". The owner accepted these findings:

  • runActions.ts: the pre-existing Overall Code Complexity finding is unchanged (penalty 2.0 -> 2.0). Its function mean rose from 5.0 to 5.5.
  • New GuardConditions.cs and evaluateGuardCondition.ts: each scores 9.38 (floor 9.0), with an Overall Code Complexity flag (mean 4.65 / 4.67 against a threshold of 4).
  • Argument-count findings on the public data-shape records GuardedSelection (5), GuardedActionProperties (7) and InteractionBinding (5). These keep backward-compatible constructors, so they were not refactored.
  • No new function-level smells.

Not run locally: hosted CI. Production UI.

@woksin
woksin merged commit e0f199d into main Oct 26, 2026
10 of 11 checks passed
@woksin
woksin deleted the scene-68-guarded-action branch October 26, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant