Repository navigation
Let dialogs keep unsaved input around outside clicks, Escape and popovers - #269
Merged
Merged
Conversation
Contributor
Author
|
Reviewer notes (Scene candidate 2026-10-24 11:55). The candidate contains the dialog dismissal work only, which is part of #257. #254 needs reporter input and is not included.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
dismissable) and by Escape (closeOnEscape). Clicks over portaled Cratis popovers keep the dialog and its unsaved input. (part of PrimeDialog: let hosts turn off outside-click dismissal and ignore portaled popovers #257)