Skip to content

Let dialogs keep unsaved input around outside clicks, Escape and popovers - #269

Merged
woksin merged 2 commits into
mainfrom
cand/scene-20261024-1155
Oct 24, 2026
Merged

woksin merged 2 commits into
mainfrom
cand/scene-20261024-1155

Conversation

@woksin

@woksin woksin commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Added

@woksin woksin added the minor label Oct 24, 2026
@woksin woksin self-assigned this Oct 24, 2026
@woksin

woksin commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes (Scene candidate 2026-10-24 11:55). The candidate contains the dialog dismissal work only, which is part of #257. #254 needs reporter input and is not included.

  • Local gates on 6083d07 (macOS):
    • yarn ci: all workspaces built and tested.
    • verify-packages: 23 packages.
    • verify-blueprints: 17 blueprints.
    • build-storybook: passed.
    • primereact browser specs: 107/107.
  • The blueprint scaffold step and the other blueprint browser suites were not run locally. Only PrimeDialog changed, so they are covered here by CI.
  • Whole-change review: passed, with 0 blocking findings. One advisory remains: the outside-click guard also matches a hidden popover that is still in the DOM.
  • Behavior note: a drag that starts outside the dialog and ends inside it, or ends on a popover, no longer closes the dialog.

@woksin
woksin merged commit 650a4c0 into main Oct 24, 2026
4 of 5 checks passed
@woksin
woksin deleted the cand/scene-20261024-1155 branch October 24, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant