Skip to content

Warn when TLS certificate validation is skipped for a remote host - #266

Merged
woksin merged 3 commits into
mainfrom
fix/tls-validation-warning
Oct 29, 2026
Merged

woksin merged 3 commits into
mainfrom
fix/tls-validation-warning

Conversation

@woksin

@woksin woksin commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Added

  • The client logs a warning at connection start when TLS certificate validation is skipped for a host other than a local one, naming the hosts for the gRPC channel and OAuth token requests and how to enable validation with skipTlsValidation=false (part of Validate the server certificate by default #263)

Changed

@woksin

woksin commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes, not part of the release note:

  • This is the first step of Validate the server certificate by default #263. The default (skipTlsValidation=true) is unchanged here. Turning validation on by default is planned for the next major, coordinated with the .NET client, and needs woksin's approval. The issue stays open for that.
  • The warning is logged once per connection, not on reconnect. It has two parts:
    • the gRPC channel, when no custom credentials are passed;
    • OAuth token requests, whenever OAuth is in use, going to the authority host when one is set.
  • Loopback hosts never warn.
  • Locally, yarn ci (3,382 tests) and yarn test pass. The kernel integration specs run in this PR's CI.
  • Review: round 1 (full review) found 2 blockers, both the same remote-authority case, plus one advisory. All three are fixed, and the round 2 quick review passed.

@woksin
woksin merged commit 562abc7 into main Oct 29, 2026
6 of 7 checks passed
@woksin
woksin deleted the fix/tls-validation-warning branch October 29, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant