Repository navigation
Harden DPoP replay store and add Redis integration specs - #342
Merged
Merged
Conversation
…rain/authproxy-2026-11-12-h
Contributor
Author
Folded items
Verificationbuild: train-h-build (2026-11-12T20:02:11.073053Z) |
Contributor
Author
|
Reviewer notes
Supersedes #341. Adds one spec-only fix on top of it: the Redis replay specs share one Redis instance, so the final assertion now ignores a synthetic-proof key left by the sibling spec. Product code is identical to #341, whose unit specs passed locally; this head passed a local Release build with warnings as errors. |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DPoP replay protection is more predictable when Redis is slow or a request lacks scope, and the Redis replay store is now covered by specs that run against a real Redis.
Changed
insufficient_scopewithout reserving its proof identifier. Successful authorization still requires an atomic replay reservation. (Real-Redis integration spec for the DPoP jti replay store #302)