Add tests and update changelog for Database.Tables FromJSON Meeting datatype

[AngelsandDevsLOL]

Proposed Changes

This change seeks to add test cases for parsing from JSON to the Meeting data type in Database/TablesTests.hs. It compares the expected and actual Maybe Meeting data type by allowing Meeting to be type Eq so that the values can be compared.

The test cases added checks if:

1. There is an invalid JSON, which should return Nothing
2. There is a valid JSON with one parameter (just the teachMethod)
3. There is a valid JSON with all fields filled

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)	X
🚦 Test update (change that only adds or modifies tests)	X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.
• I have updated the project Changelog (this is required for all changes).

After opening your pull request:

• I have verified that the CircleCI checks have passed.
• I have requested a review from a project maintainer.

Questions and Comments

I'm not too sure what the runDb does, because it feels redundant and unnecessary for these test cases. I kept the runDb for the sake of keeping the testing files consistent, but I don't see how the database is relevant here. I noticed at the bottom of the file, we run the test cases using withDatabase, which is defined as using the withResource from the Test.Tasty library. My guess is that other test cases interact with the database, which is why that part of the code is there, but does that mean it should be kept for this test suite, even if it doesn't need to interact with the database?

[coveralls]

Coverage Report for CI Build 692

Coverage increased (+0.4%) to 57.792%

Details

• Coverage increased (+0.4%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	3945
Covered Lines:	2334
Line Coverage:	59.16%
Relevant Branches:	964
Covered Branches:	503
Branch Coverage:	52.18%
Branches in Coverage %:	Yes
Coverage Strength:	163.4 hits per line

---

💛 - Coveralls