Skip to content

feat: add production Helm chart controls - #47

Merged
CoreyLeath-code merged 12 commits into
mainfrom
codex/helm-production-chart
Nov 13, 2026
Merged

CoreyLeath-code merged 12 commits into
mainfrom
codex/helm-production-chart

Conversation

@CoreyLeath-code

@CoreyLeath-code CoreyLeath-code commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add a configurable Helm chart for the LogSight API with hardened pod/container defaults
  • include HPA, PDB, restrictive ingress/egress NetworkPolicy, ServiceAccount, health probes, and resource controls
  • add chart documentation and a Helm lint/template CI workflow

Operational boundary

  • Redis, OTLP, Kafka, and other dependencies remain deployment-owned and require explicit NetworkPolicy egress rules
  • credentials are supplied through externally managed Secret references, not chart values

Validation

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T22:06:55.919662Z be163d3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@CoreyLeath-code
CoreyLeath-code merged commit 60bb374 into main Nov 13, 2026
7 of 8 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be163d33cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
- name: logsight-api
image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Support digest-qualified image references

For deployments using the immutable image digests advertised in the chart guide, this template always inserts a tag separator: setting image.tag=sha256:… produces repository:sha256:…, while putting repository@sha256:… in image.repository appends :0.2.0 to the digest. Both are invalid image references, so those pods cannot start. Add a digest-aware rendering path using repository@sha256:…, or support a complete image reference without appending a tag.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant