fix(collab): preserve initial sync delivery under backpressure - #590
Draft
marcodantonio-netsons wants to merge 1 commit into
Draft
marcodantonio-netsons wants to merge 1 commit into
marcodantonio-netsons wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large sites send thousands of initial collaboration replies through one socket. The server previously ignored backpressure and continued generating replies, leaving some documents empty and the editor write gate closed indefinitely. Serialize requests per connection, await Bun's drain after a queued send, and reconnect when delivery fails. Pub/sub overflow also closes the connection so state-vector recovery can catch up.
Verified with
bun test(7,056 passed),bun run build,bun run lint, andgit diff --check. Regression tests cover drain ordering without duplicate sends, disconnect cancellation, and dropped-frame recovery. Existing real-socket collaboration tests pass. Browser verification on an isolated 1,602-page / 754-component site went from 2,061 empty document trees to zero; layer rename, undo/redo and persistence after reload passed. Local test data and screenshots are excluded. No database schema changes.