fix(editor): seed detached collaboration documents on first use - #586
Draft
marcodantonio-netsons wants to merge 1 commit into
Draft
marcodantonio-netsons wants to merge 1 commit into
marcodantonio-netsons wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the collaborative provider connected, loading or disconnecting a site eagerly created Yjs copies and undo managers for every page, component and layout. Keep detached row seeds as JSON references and initialize each document on first access, attaching observers and undo tracking after seeding. Provider-owned server seeding is unchanged.
Tests cover one-time allocation, first-edit undo/redo, and restoring an untouched deleted page through roster undo. Verified with bun test (7,056 passed), bun run build, bun run lint and git diff --check. A local 1,602-page / 754-component registry initialized in 1.1 ms with zero Y docs; first access to the 1,941-node homepage took 6.0 ms. Eager seeding of a 100-page / 50-component sample (115,365 nodes) took 365.8 ms. Full connected editor responsiveness remains under investigation. No database changes.