refactor(plugins): separate manifest validation stages#254
Draft
DavidBabinec wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
parsePluginManifestas a short, ordered coordinatorWhy
parsePluginManifestwas a high-complexity maintenance hotspot. Isolating each invariant makes future plugin-schema work easier to review and test without adding a parallel parser or compatibility layer.Impact
No intended user-facing behavior change. Valid manifests normalize as before; invalid manifests continue to fail with the same messages.
Verification
bun test src/__tests__/plugins/pluginManifest.test.ts src/__tests__/plugins/pluginMarketplaceFields.test.ts(30 pass)bun run lintbun run buildbun test(full suite passed)