Skip to content

fix(editor): render loops in page preview#242

Merged
DavidBabinec merged 1 commit into
mainfrom
fix/preview-loop-parity
Jul 22, 2026
Merged

fix(editor): render loops in page preview#242
DavidBabinec merged 1 commit into
mainfrom
fix/preview-loop-parity

Conversation

@DavidBabinec

Copy link
Copy Markdown
Contributor

Summary

  • build Preview page through the authenticated server runtime-preview boundary
  • preserve current-draft semantics while resolving loop and media data before publishing
  • add abortable loading, error, retry, and toast handling
  • add client, component, and server regression coverage plus SITE-016/loop documentation

Root cause

PreviewOverlay called the pure client publisher directly without loopData, so base.loop rendered no items even though the editor canvas and public server renderer prefetched them.

User impact

Preview page now renders loop-backed content consistently with the editor canvas and public page, without publishing the draft.

Verification

  • bun test src/__tests__/server/cmsRuntimeHandlers.test.ts src/__tests__/publisher/previewOverlay.test.tsx src/__tests__/persistence/cmsRuntimeClient.test.ts — 44 passed
  • bun test — 6,237 passed, 0 failed
  • bun run build
  • bun run lint
  • Chromium same-flow retest at 1440×900: Preview and the live route both rendered ISS-234 LOOP ROW

Fixes #234

@DavidBabinec
DavidBabinec marked this pull request as ready for review July 22, 2026 21:13
@DavidBabinec
DavidBabinec merged commit 9030c09 into main Jul 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Preview mode cannot show loops, live page view can

1 participant