Skip to content

fix: remove ci_run_id from Rule 1 condition to support Cloud Build repos#48

Merged
Dorac merged 1 commit into
masterfrom
fix/rule1-ci-run-id-condition
Jun 22, 2026
Merged

fix: remove ci_run_id from Rule 1 condition to support Cloud Build repos#48
Dorac merged 1 commit into
masterfrom
fix/rule1-ci-run-id-condition

Conversation

@Dorac

@Dorac Dorac commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Problem

Rule 1 in Claude's prompt had the condition:

ci_conclusion is not "success" OR ci_run_id is empty

For repos using Cloud Build (not GitHub Actions), ci_run_id is always empty. This meant Rule 1 always triggered regardless of whether CI actually passed, labeling every Dependabot PR as ai-skipped-ci-failed.

Fix

  • Rule 1: now only checks ci_conclusion is not "success" — empty ci_run_id no longer affects the decision
  • Step 2: only runs when CI failed AND ci_run_id is non-empty; if ci_run_id is empty and CI failed, the comment shows "N/A — CI run ID unavailable, check CI provider directly"
  • Step 3: condition simplified to ci_conclusion is "success" (removed the ci_run_id is non-empty requirement, since codebase grep doesn't need a run ID)

Impact

  • GitHub Actions repos (cp-crypto-swap, cp-node-proxy): no behavior change — ci_run_id is always provided
  • Cloud Build repos (cp-node-graphql-endpoint): CI pass → now correctly proceeds to Rule 2/3/4; CI fail → label ai-skipped-ci-failed with N/A in failure details

ci_run_id is unavailable for non-GitHub-Actions CI (e.g. Cloud Build).
The previous Rule 1 triggered on empty ci_run_id regardless of CI outcome,
causing all Cloud Build PRs to be labeled ai-skipped-ci-failed even when
CI passed. Rule 1 now only checks ci_conclusion; ci_run_id emptiness only
affects whether Step 2 log analysis can run.
@Dorac Dorac disabled auto-merge June 22, 2026 11:17
@Dorac Dorac merged commit 9f46a27 into master Jun 22, 2026
5 of 9 checks passed
@Dorac Dorac deleted the fix/rule1-ci-run-id-condition branch June 22, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants