fix(research): reconcile public-release privacy gate with current main - #409
Open
seonghobae wants to merge 11 commits into
Open
fix(research): reconcile public-release privacy gate with current main#409seonghobae wants to merge 11 commits into
seonghobae wants to merge 11 commits into
Conversation
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Public Research Commons release packaging still needs a product-owned, fail-closed privacy boundary before a fixture can be treated as publishable evidence. Historical PR #301 contained the reviewed security/privacy implementation but was 38 protected-main commits behind, diverged, and carried 69 historical commits. Protected
main@c3eff8d2fbd7e69dccbc3b1f7bf166969c209303had not modifiedsrc/research_release.rs,docs/RESEARCH_GOVERNANCE.md, or the research-publication contract files after #301's merge base, so this PR replayed that reviewed work onto current main without importing stale ancestry or unrelated changes, then repaired two current-head review findings test-first.Current-main TDD lineage
d99db02212d3193f39307f0654a14dbec43425daadded the nine reviewed research-publication contracts against current main before the implementation replay.e6706af7ce501c9c3e46cc9cc0825f0afe77a668replayed the reviewed finalsrc/research_release.rsanddocs/RESEARCH_GOVERNANCE.mdblobs from fix(research): harden public-release identity privacy gate #301 headbf46714a900a0ef19f63cdceb5ab8d0188350b88.04bab47c5e2478c82d9b3ff0173f16277c1f78a7pinnedkey_research_participant_ref, camelCase equivalent, and the deliberately conservativetokenized_scorerejection.051a711f9fb846ee85ab5393d078fc4b3009802bapplies credential/compound checks to prefixes beforeresearch_participant_refand recognizeskey/keysas credential words.34601e7300d0719554b4da556c906d702586fbeedocuments the intentional fail-closed false-positive tradeoff and the operator remediation path.src/research_release.rs,docs/RESEARCH_GOVERNANCE.md, and the ninetests/research_publication_*files changed.Privacy contract
research_participant_refpublic namespace, including reviewed author-metadata exceptions, without weakening restricted markers;Bounded context
Psychometrics Commons owns enrollment/consent/normalized ingestion/reference orchestration and this pre-publication product privacy gate.
semantic-data-portalremains the immutable external research catalog/release-registration owner. This change does not duplicate Keyverse identity authority, TEPP analysis, Gyeot collection, or fast-mlsirm psychometric kernels, and it does not add direct cross-service database access.Closes #260
Acceptance
Do not merge until the unchanged exact head independently passes Runtime CI including exact owned-production statement/branch coverage, rustfmt/Clippy/rustdoc, Security/SAST, SPDX SBOM, supply-chain provenance, every live required organization workflow, zero valid unresolved findings, and qualifying independent non-author/non-last-pusher approval under the active ruleset. Pending, queued, skipped, cancelled, absent, stale, predecessor, synthetic, or model-only evidence is not passing. Never self-approve or use administrator bypass.
Supersedes stale/diverged #301 as the clean current-main landing vehicle; historical checks and reviews do not transfer to this exact head.