Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,6 @@ Optimized metric route processing to O(N) by creating a mapping of routes direct
## 2024-07-13 - [Optimize Export Dictionary FK lookups]
**Learning:** Found O(N * C * E) performance bottleneck in ERD export dictionaries due to repeated array searching with `edges.some()` inside a nested loop over nodes and columns.
**Action:** Replace repeated linear array scans for edges by precomputing O(1) Set lookups of foreign key column handles per node before looping.
## 2024-11-20 - Avoid Array.from for String Iteration in Hot Paths
**Learning:** Using `Array.from(string)` to iterate over characters and map them creates an intermediate array, increasing garbage collection overhead, especially in hot paths like ERD graph handle generation which runs per column.
**Action:** Prefer `for...of` loops over `Array.from` for string character iteration to prevent intermediate array allocations and reduce garbage collection pressure.
4 changes: 4 additions & 0 deletions frontend/src/App.coverage.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,7 @@ describe('App orchestration coverage', () => {
it('logs auto-layout failures and preserves nodes added after the undo snapshot', async () => {
await renderReadyApp()
fireEvent.click(screen.getByRole('button', { name: '다이어그램' }))
await waitFor(() => expect(screen.getAllByRole('button', { name: '열기' }).length).toBeGreaterThan(0))
vi.useFakeTimers()
fireEvent.click(screen.getAllByRole('button', { name: '열기' })[0]!)
await act(async () => {
Expand Down Expand Up @@ -641,6 +642,7 @@ describe('App orchestration coverage', () => {
.mockRejectedValueOnce(new Error('terminal refresh down'))
await renderReadyApp()
fireEvent.click(screen.getByRole('button', { name: '다이어그램' }))
await waitFor(() => expect(screen.getAllByRole('button', { name: '열기' }).length).toBeGreaterThan(0))
vi.useFakeTimers()
fireEvent.click(screen.getAllByRole('button', { name: '열기' })[0]!)
await act(async () => {
Expand Down Expand Up @@ -744,6 +746,7 @@ describe('App orchestration coverage', () => {
}))
await renderReadyApp()
fireEvent.click(screen.getByRole('button', { name: '다이어그램' }))
await waitFor(() => expect(screen.getAllByRole('button', { name: '열기' }).length).toBeGreaterThan(0))
vi.useFakeTimers()
fireEvent.click(screen.getAllByRole('button', { name: '열기' })[0]!)
await act(async () => {
Expand Down Expand Up @@ -784,6 +787,7 @@ describe('App orchestration coverage', () => {
})
await renderReadyApp()
fireEvent.click(screen.getByRole('button', { name: '다이어그램' }))
await waitFor(() => expect(screen.getAllByRole('button', { name: '열기' }).length).toBeGreaterThan(0))
vi.useFakeTimers()
fireEvent.click(screen.getAllByRole('button', { name: '열기' })[0]!)
await act(async () => {
Expand Down
18 changes: 13 additions & 5 deletions frontend/src/erd/handleUtils.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
export function sanitizeHandleId(columnName: string): string {
const encoded = Array.from(columnName, (char) => {
// Array.from only yields non-empty Unicode scalars, so codePointAt(0) is defined.
return char.codePointAt(0)!.toString(16).padStart(4, '0')
}).join('-')
if (!columnName) return 'c-empty';

return `c-${encoded || 'empty'}`
let encoded = '';
let isFirst = true;
// ⚡ Bolt: Using for...of avoids intermediate array allocation and GC overhead
// that would be caused by Array.from(string) in this hot path.
for (const char of columnName) {
if (!isFirst) encoded += '-';
// for...of only yields non-empty Unicode scalars, so codePointAt(0) is defined.
encoded += char.codePointAt(0)!.toString(16).padStart(4, '0');
isFirst = false;
}

return `c-${encoded}`;
}

export function sourceColumnHandleId(columnName: string): string {
Expand Down
Loading