π‘οΈ Sentinel: [MEDIUM] Add input validation to exported functions - #97
π‘οΈ Sentinel: [MEDIUM] Add input validation to exported functions#97seonghobae wants to merge 1 commit into
Conversation
Adds validation for conf.level in icci, and nested and adj in vuongtest to prevent raw execution errors from leaking internal details.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 31 minutes Limit details: Youβve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review detailsβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (!is.character(adj) || length(adj) != 1 || is.na(adj)) { | ||
| stop("adj must be a single character string", call. = FALSE) | ||
| } |
There was a problem hiding this comment.
π Info: adj value not restricted to valid set
Validation checks adj is a single character string but not that it is one of "none"/"aic"/"bic". An unrecognized value like "AIC" silently skips both adjustment branches (R/vuongtest.R:165-170), yielding an unadjusted result rather than an error. Not a regression; match.arg would be stricter.
Was this helpful? React with π or π to provide feedback.
opencode-agent
Bot
added
priority: medium
1 participant
π¨ Severity: MEDIUM
π‘ Vulnerability: Missing input validation on exported functions
icciandvuongtestallowed invalid types to propagate deeply into logic or conditional checks, eventually causing raw R execution errors that leak internal contexts to standard error (e.g.$ operator is invalid for atomic vectorsorargument is not interpretable as logical).π― Impact: Attackers could pass malformed arguments to intentionally trigger internal unhandled exceptions and map internal control flow and variable names, exposing execution context.
π§ Fix: Added strict type, length, and bounds checking for
conf.level,nested, andadjarguments at the start oficciandvuongtest, failing securely usingstop("...", call. = FALSE).β Verification: Ran
R CMD INSTALL .and verified tests pass. Also executed manually crafted payloads confirming the securestop()errors out without exposing stack details.PR created automatically by Jules for task 14153892756077763940 started by @seonghobae