🛡️ Sentinel: [MEDIUM] Fix error handling leaking call stacks via unvalidated inputs - #84
🛡️ Sentinel: [MEDIUM] Fix error handling leaking call stacks via unvalidated inputs#84seonghobae wants to merge 8 commits into
Conversation
Adds input validation using `stop(..., call. = FALSE)` and `match.arg()` at the top of `vuongtest()` and `icci()` to prevent users from passing incorrect types (like arrays where scalars are expected) which would bypass the module's secure error boundaries and leak internal call stacks and R execution logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough
Changes입력 검증
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head727f62b7497b8b14f62a8e9049ca3a9baa4d4028. -
Head SHA:
727f62b7497b8b14f62a8e9049ca3a9baa4d4028 -
Workflow run: 31458096008
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-input-validation.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-input-validation.R"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-input-validation.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-input-validation.R"]
R2 --> V2["targeted test run"]
|
Adds input validation using stop(..., call. = FALSE) at the top of vuongtest() and icci() to prevent users from passing incorrect types (like arrays where scalars are expected, or NA where finite bounds are expected) which would bypass the module's secure error boundaries and leak internal call stacks and R execution logic.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head19607c6087284ec787af47490650a4140650215a. -
Head SHA:
19607c6087284ec787af47490650a4140650215a -
Workflow run: 31462496395
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-input-validation.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-input-validation.R"]
R2 --> V2["targeted test run"]
|
@coderabbitai review |
✅ Action performedReview finished.
|
Adds input validation using stop(..., call. = FALSE) at the top of vuongtest() and icci() to prevent users from passing incorrect types (like arrays where scalars are expected, or NA where finite bounds are expected) which would bypass the module's secure error boundaries and leak internal call stacks and R execution logic.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head3d8848c97db6a2d132dbcb01923b401bbd6821f9. -
Head SHA:
3d8848c97db6a2d132dbcb01923b401bbd6821f9 -
Workflow run: 31497350819
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-input-validation.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-input-validation.R"]
R2 --> V2["targeted test run"]
opencode-agent
Bot
added
priority: medium
1 participant
What
nestedvalues before model dispatch.adjvalues with a package-owned message.conf.levelvalues.call. = FALSE.Test-first evidence
727f62b7497b8b14f62a8e9049ca3a9baa4d4028, R-CMD-check run31457987851, job93675642332, produced 28 failures. Zero-length and missing values reachedllcont(NULL)or raw R control-flow errors with populated calls.19607c6087284ec787af47490650a4140650215a.31458868227: success.31458868239: success.31458868205: success.Review state
OpenCode's current-head
CHANGES_REQUESTEDis not a source-test regression. Central run31462496395failed in its network-isolated R coverage sandbox before executing the suite because target-package importsCompQuadForm,mvtnorm,lavaan (>= 0.6-6), andsandwichwere unavailable. The same exact head passed the repository-owned R-CMD-check above. The central coverage contract remains authoritative and must be repaired or rerun by its owning.githubwriter; this PR remains active-PR evidence and is not merge-ready until current-head review and repository policy are satisfied.Original task: Jules 14175515133901881384
Summary by CodeRabbit
버그 수정
icci()의 신뢰수준 입력값이 단일 유한 숫자이며 0과 1 사이인지 검증합니다.vuongtest()의nested입력값 타입과 결측 여부를 확인합니다.adj입력값이 허용된 옵션(none,aic,bic) 중 하나인지 검증합니다.테스트